fixes #1804 #1806
Merged
fixes #1804 #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
this change looks contradictory to @CohenCyril 's suggestion in the original discussion |
Member
Author
|
Yes, the PR was done quickly to check the CI to fuel the discussion. It could be closed now, except that @agontard maybe found an inconsistency in MathComp proper (shouldn't the arguments of |
Co-authored-by: @agontard
affeldt-aist
force-pushed
the
fixes_1804
branch
from
3709f01 to
22f98d3
Compare
Member
Author
|
I guess that the conclusion of the discussion about issue #1804 is that the change has one advantage and no immediate downsides so Iet's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @agontard
Motivation for this change
fixes #1804
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers